-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-34624][state/changelog] Enable local recovery in ChangelogRescalingITCase #24470
Conversation
@Zakelly @masteryhx Would you help to take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The spotless-check failed, but LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
LGTM if CI passed.
Thanks for the review, the local rescaling for the changelog state backend is not fully supported, I disabled changelog in AutoRescalingITCase temporarily. |
What is the purpose of the change
Enable local recovery in ChangelogRescalingITCase, since the local recovery of changelog state backend was supported by FLINK-27693 and FLINK-27692.
Brief change log
Verifying this change
Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (no)Documentation