Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-34624][state/changelog] Enable local recovery in ChangelogRescalingITCase #24470

Merged
merged 3 commits into from
Mar 12, 2024

Conversation

fredia
Copy link
Contributor

@fredia fredia commented Mar 8, 2024

What is the purpose of the change

Enable local recovery in ChangelogRescalingITCase, since the local recovery of changelog state backend was supported by FLINK-27693 and FLINK-27692.

Brief change log

  • Enable local recovery in ChangelogRescalingITCase
  • Remove the changelog configuration check from TestStreamEnvironment

Verifying this change

Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@fredia fredia requested a review from masteryhx March 8, 2024 11:05
@fredia
Copy link
Contributor Author

fredia commented Mar 8, 2024

@Zakelly @masteryhx Would you help to take a look?

@flinkbot
Copy link
Collaborator

flinkbot commented Mar 8, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@Zakelly Zakelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The spotless-check failed, but LGTM.

Copy link
Contributor

@masteryhx masteryhx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.
LGTM if CI passed.

@fredia
Copy link
Contributor Author

fredia commented Mar 12, 2024

Thanks for the review, the local rescaling for the changelog state backend is not fully supported, I disabled changelog in AutoRescalingITCase temporarily.

@fredia fredia merged commit 94b55d1 into apache:master Mar 12, 2024
spoon-lz pushed a commit to spoon-lz/flink that referenced this pull request Mar 14, 2024
spoon-lz pushed a commit to spoon-lz/flink that referenced this pull request Mar 14, 2024
hanyuzheng7 pushed a commit to hanyuzheng7/flink that referenced this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants