-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-32513][core] Add predecessor caching #24475
Conversation
89fdb18
to
8645d35
Compare
Hi @zhuzhurk could you please review the PR in you available time? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for creating the fix. @jeyhunkarimov
I have two comments. Please take a look.
flink-core/src/test/java/org/apache/flink/api/dag/TransformationTest.java
Show resolved
Hide resolved
...java/org/apache/flink/streaming/api/transformations/AbstractMultipleInputTransformation.java
Outdated
Show resolved
Hide resolved
Thanks @zhuzhurk for the review. I addressed them. Could you please check again? |
flink-core/src/test/java/org/apache/flink/api/dag/TransformationTest.java
Show resolved
Hide resolved
flink-core/src/test/java/org/apache/flink/api/dag/TransformationTest.java
Outdated
Show resolved
Hide resolved
...java/org/apache/flink/streaming/api/transformations/AbstractMultipleInputTransformation.java
Show resolved
Hide resolved
...ava/org/apache/flink/streaming/api/transformations/AbstractBroadcastStateTransformation.java
Show resolved
Hide resolved
flink-core/src/test/java/org/apache/flink/api/dag/TransformationTest.java
Outdated
Show resolved
Hide resolved
b07d0d3
to
eaa69e3
Compare
flink-core/src/test/java/org/apache/flink/api/dag/TransformationTest.java
Outdated
Show resolved
Hide resolved
.../test/java/org/apache/flink/streaming/api/transformations/GetTransitivePredecessorsTest.java
Outdated
Show resolved
Hide resolved
.../test/java/org/apache/flink/streaming/api/transformations/GetTransitivePredecessorsTest.java
Outdated
Show resolved
Hide resolved
.../test/java/org/apache/flink/streaming/api/transformations/GetTransitivePredecessorsTest.java
Show resolved
Hide resolved
eaa69e3
to
0ce29c2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Thanks for addressing all the comments! @jeyhunkarimov
Would you squash the last two commits and rebase the changes onto the latest Flink master branch?
0ce29c2
to
7d343da
Compare
Thanks a lot @zhuzhurk for your reviews.
Done. |
What is the purpose of the change
This pull request adds caching capability to
Transformation
Brief change log
Transformation::getTransitivePredecessors()
to utilize cacheTransformation::getTransitivePredecessorsInternal()
Verifying this change
This change added tests to
org.apache.flink.api.dag.TransformationTest::testPredecessorCache()
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (no)Documentation