Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-34719][streaming] Fix unstable test StreamRecordTest.testWithTimestamp above jdk8 #24519

Merged
merged 1 commit into from Mar 18, 2024

Conversation

Jiabao-Sun
Copy link
Contributor

What is the purpose of the change

[FLINK-34719][streaming] Fix unstable test StreamRecordTest.testWithTimestamp above jdk8

Brief change log

Fix unstable test StreamRecordTest.testWithTimestamp above jdk8

Verifying this change

use jdk11

mvn test -Dtest=oorg.apache.flink.streaming.runtime.streamrecord.StreamRecordTest

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not documented)

@Jiabao-Sun
Copy link
Contributor Author

Hi @RyanSkraba.
Would you help review this PR when you have time?
Thanks.

@flinkbot
Copy link
Collaborator

flinkbot commented Mar 18, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@RyanSkraba RyanSkraba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the quick fix! I think that it's OK not to test the message in this case -- the fact that it is a ClassCastException is already enough!

@Jiabao-Sun Jiabao-Sun merged commit 8ec5e7e into apache:master Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants