Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][FLINK-34723][parquet] Restrict parquet map keys to be not null #24522

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

xccui
Copy link
Member

@xccui xccui commented Mar 19, 2024

What is the purpose of the change

We hit the following exception when reading a parquet file generated by Flink.

Map keys must be annotated as required.

Brief change log

Restricted the map key type to be not null in ParquetSchemaConverter.

Verifying this change

  • Modified the existing tests to use not null key types.
  • Added a new test testNullableMapKeyNotAllowed.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (doc updated)

@flinkbot
Copy link
Collaborator

flinkbot commented Mar 19, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@xccui xccui changed the title [FLINK-34723][parquet] Restrict parquet map keys to be not null [WIP][FLINK-34723][parquet] Restrict parquet map keys to be not null Mar 19, 2024
@xccui xccui marked this pull request as draft March 19, 2024 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants