Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-34727][REST]fix rest request writer future not return #24525

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

moesome
Copy link

@moesome moesome commented Mar 19, 2024

What is the purpose of the change

"thenAccept()" did not return sendResponse's future, causing the server shutdown process before the request was sent complete.

Brief change log

change AbstractRestHandler respondToRequest return sendRequest inner future

Verifying this change

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): don't know
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

[FLINK-34727][REST]fix rest request writer future not return

@flinkbot
Copy link
Collaborator

flinkbot commented Mar 19, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants