Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-34745] Improve validations for a period in Time Travel #24534

Merged
merged 4 commits into from
Mar 20, 2024

Conversation

dawidwys
Copy link
Contributor

What is the purpose of the change

The provided SQLs are invalid, however the current code base fails on unexpected locations giving unhelpful messages. This PR improves the validation which results in proper error messages.

Verifying this change

Added tests.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Mar 19, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@snuyanzin snuyanzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for addressing comment
i have another nit one

…/table/planner/calcite/FlinkCalciteSqlValidator.java

Co-authored-by: Sergey Nuyanzin <sergey.nuyanzin@aiven.io>
@dawidwys dawidwys merged commit 4142c43 into apache:master Mar 20, 2024
@dawidwys dawidwys deleted the flink34745 branch March 20, 2024 14:14
hanyuzheng7 pushed a commit to hanyuzheng7/flink that referenced this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants