Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-34551][core] Refactor retry logic in FutureUtils #24578

Closed

Conversation

kumar-mallikarjuna
Copy link
Contributor

What is the purpose of the change

FutureUtils has different retry methods and multiple implementations which are overlapping. This PR refactors the retryOperation() and retryOperationWithDelay() methods.

Brief change log

  • Make the retryOperation() support scheduled exection
  • Remove retryOperationWithDelay()

Verifying this change

This change is already covered by existing tests, such as FutureUtilsTest.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (don't know) - The fabric8 client uses FutureUtils
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@flinkbot
Copy link
Collaborator

flinkbot commented Mar 27, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@XComp
Copy link
Contributor

XComp commented Apr 5, 2024

Closing the PR. See FLINK-34551 for more context

@XComp XComp closed this Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants