Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-31497][table] Drop the deprecated CatalogViewImpl #24579

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jeyhunkarimov
Copy link
Contributor

What is the purpose of the change

Drop the deprecated CatalogViewImpl

Brief change log

  • Refactor documentation
  • Remove CatalogViewImpl
  • Refactor python code that uses CatalogViewImpl

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)

@flinkbot
Copy link
Collaborator

flinkbot commented Mar 27, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@jeyhunkarimov jeyhunkarimov force-pushed the FLINK-31497 branch 5 times, most recently from 55cfdd9 to a380e04 Compare March 28, 2024 12:37
Copy link
Contributor

@JingGe JingGe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeyhunkarimov jeyhunkarimov force-pushed the FLINK-31497 branch 2 times, most recently from 887cfb9 to d0170bd Compare March 28, 2024 17:04
@jeyhunkarimov
Copy link
Contributor Author

I think we cannot (yet) remove CatalogViewImpl, because python catalog depends on TableSchema (deprecated). But the new changes CatalogView uses the new Schema abstraction. We can convert the new abstraction to the old one (
(there is already conversion from TableSchema -> Schema or old to new abstraction), to make failing python test work, but I dont think it is a good idea. I would propose to wait until schema abstractions converge to Schema and ResolvedSchema. WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants