Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-34956][doc] Fix the config type wrong of Duration #24581

Merged
merged 1 commit into from
Mar 28, 2024
Merged

[FLINK-34956][doc] Fix the config type wrong of Duration #24581

merged 1 commit into from
Mar 28, 2024

Conversation

1996fanrui
Copy link
Member

What is the purpose of the change

The Config type is Boolean, but it should be Duration.

https://nightlies.apache.org/flink/flink-docs-master/docs/deployment/config/

image

Brief change log

  • [FLINK-34956][doc] Fix the config type wrong of Duration

1996fanrui
1996fanrui commented Mar 28, 2024
View reviewed changes
Copy link
Member Author

@1996fanrui 1996fanrui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @RocMarshal

@flinkbot
Copy link
Collaborator

flinkbot commented Mar 28, 2024 •
edited

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

RocMarshal
RocMarshal approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@RocMarshal RocMarshal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @1996fanrui for the catching & patch.
LGTM +1. :)

1996fanrui
1996fanrui commented Mar 28, 2024
View reviewed changes
Copy link
Member Author

@1996fanrui 1996fanrui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @RocMarshal for the quick review, merging~

@1996fanrui 1996fanrui merged commit f31c128 into apache:master Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RocMarshal RocMarshal RocMarshal approved these changes

Assignees
No one assigned
Labels
component=Documentation
Projects
None yet
Milestone
No milestone
3 participants
@1996fanrui @flinkbot @RocMarshal