Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-21943][core] Remove redundant checkNotNull in Transformation#setResources #24602

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

plugatarev
Copy link
Contributor

What is the purpose of the change

Remove redundant checkNotNull in setResources

Brief change log

  • Remove redundant checkNotNull in setResources
  • Replace HashMap with EnumMap for managedMemoryOperatorScopeUseCaseWeights
  • Simplify assertThat to assertEquals
  • Add tests

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no

@flinkbot
Copy link
Collaborator

flinkbot commented Apr 2, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Member

@reswqa reswqa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I left some comments, please take a look.

BTW, we should rename the commit message to [FLINK-21943][core] Remove redundant checkNotNull in Transformation#setResources

@plugatarev plugatarev requested a review from reswqa April 2, 2024 04:51
@reswqa reswqa changed the title [FLINK-21943] Remove redundant checkNotNull [FLINK-21943][core] Remove redundant checkNotNull in Transformation#setResources Apr 2, 2024
Copy link
Member

@reswqa reswqa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick update, LGTM.

@plugatarev
Copy link
Contributor Author

Thanks for the quick update, LGTM.

Thanks for the quick review, merge please

@reswqa reswqa merged commit 8a18b11 into apache:master Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants