-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-34123][core][type] Introduce built-in serialization support for map and lists #24634
Conversation
@reswqa Hi, could you help take a look when you have time? |
docs/content/docs/dev/datastream/fault-tolerance/serialization/types_serialization.md
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@X-czh Sorry for the delay. LGTM except the documentation part, could you please address that and rebase on latest master branch?
@reswqa Thanks for the review. I've rebased on latest master branch, and it has been highlighted in the doc content as follows:
Would you mind taking a look again when you have time? |
Thanks @X-czh, I think we only need two commits. One for the implementation and one for documentation. |
…r Map, List, and Collection
…for Map, List, and Collection
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will merge this after CI passed.
What is the purpose of the change
Introduce built-in serialization support for map and lists, which falls back to Kyro previously.
Brief change log
Introduce built-in serialization support for map and lists when extracting types. The serializers and de-serializers have already been defined previously.
Set
is another common Java collection type, but there's no built-in serializer for it yet (MultiSetTypeInformation
utilizesMapSerializer
underneath, but it could be more efficient for commonSet
), we can add support for it in a following PR.Verifying this change
This change added tests that validates maps and lists are serialized using the built-in serializer instead of Kyro.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (yes / no)Documentation