Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-32080][FLIP-306][checkpoint] Restoration of FileMergingSnapshotManager #24640

Closed
wants to merge 4 commits into from

Conversation

ljz2051
Copy link
Contributor

@ljz2051 ljz2051 commented Apr 9, 2024

What is the purpose of the change

This pull request introduces the restoration mechanism for FileMergingSnapshotManager. See FLIP-306 for more information.

Brief change log

  • Restore and re-register the SegmentFileStateHandles into FileMergingSnapshotManager.

Verifying this change

This change added unit tests (FileMergingSnapshotManagerTestBase#testRestore). And the end-to-end tests will be added after FLIP-306 is almost ready.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: yes
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? yes
  • If yes, how is the feature documented? (not applicable)

@flinkbot
Copy link
Collaborator

flinkbot commented Apr 9, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@ljz2051
Copy link
Contributor Author

ljz2051 commented Apr 9, 2024

@Zakelly @fredia @masteryhx Could you please take a look ?

@ljz2051 ljz2051 force-pushed the FLINK-32080 branch 2 times, most recently from f91756c to a519550 Compare April 15, 2024 08:58
Copy link
Contributor

@Zakelly Zakelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, I left some comments.

@ljz2051 ljz2051 requested a review from Zakelly April 30, 2024 08:49
Copy link
Contributor

@Zakelly Zakelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! LGTM +1

@Zakelly Zakelly closed this in afe4c79 May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants