Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-35091][Metrics][Minor] Fix incorrect warning msg in JM log when use metric reporter #24654

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

leosanqing
Copy link

Desc

I encountered an issue while upgrading Flink from version 1.14 to 1.18. After the upgrade, I noticed that some monitoring metrics were not being reported to InfluxDB.
Upon checking the Job Manager (JM) logs, I found an error indicating that the previously used classes are no longer supported. However, there seems to be an oddly phrased error message that looks like it might have been written incorrectly.

The error message reads: "The reporter configuration of '{}' configures the reporter class, which is no a no longer supported approach to configure reporters." + " Please configure a factory class instead:"

I believe the correct phrasing should be: "The reporter configuration of '{}' configures the reporter class, which is a no longer supported approach to configure reporters." + " Please configure a factory class instead:"

It appears that the words "no a" were accidentally added, making the sentence grammatically incorrect and potentially confusing for users.

What is the purpose of the change

Fix incorrect warning msg in JM log when use metric reporter

Brief change log

Just warning log print

The error message reads: "The reporter configuration of '{}' configures the reporter class, which is no a no longer supported approach to configure reporters." + " Please configure a factory class instead:"
I believe the correct phrasing should be: "The reporter configuration of '{}' configures the reporter class, which is a no longer supported approach to configure reporters." + " Please configure a factory class instead:"

image

Verifying this change

No need to test

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no )
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)

@flinkbot
Copy link
Collaborator

flinkbot commented Apr 12, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants