[FLINK-35125][state] Implement ValueState for ForStStateBackend #24671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredia
reviewed
Apr 17, 2024
| * @param <K> Type of the key in the state. | ||
| */ | ||
| @Internal | ||
| public interface InternalSyncState<K> { |
There was a problem hiding this comment.
SyncState is a little bit strange, I'm not sure if InternalUnderlyingState would be better, maybe we can seek other people’s opinions.
| * | ||
| * @return True if supported, false if not. | ||
| */ | ||
| default boolean isSupportMultiGet() { |
There was a problem hiding this comment.
IIUC, InternalSyncState is a high-level base interface for different state backend, isSupportMultiGet() seems to be bound to a specific implementation. I think supportBatchGet/supportBatchPut may be better, WDYT?
|
|
||
| protected final WriteOptions writeOptions; | ||
|
|
||
| protected final TypeSerializer<K> keySerializer; |
There was a problem hiding this comment.
IsnamespaceSerializer needed here?
|
|
||
| protected final TypeSerializer<V> valueSerializer; | ||
|
|
||
| private final ThreadLocal<SerializedCompositeKeyBuilder<K>> serializedKeyBuilder; |
There was a problem hiding this comment.
Will serializedKeyBuilder be accessed concurrently? How about adding some comments about ThreadLocal?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This pull request implements the ValueState for ForStStateBackend.
Brief change log
Verifying this change
This change added tests and can be verified by ForStValueStateTest.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation