[FLINK-35148][core] Improve InstantiationUtil for checking nullary pu… #24675
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…blic constructor
What is the purpose of the change
https://issues.apache.org/jira/browse/FLINK-35148
InstantiationUtil#hasPublicNullaryConstructor checks whether the given class has a public nullary constructor. The implementation can be improved a bit: the
Modifier#isPublic
check within the for-loop can be skipped as the Class#getConstructors() only returns public constructors.We can also add a negative unit test for this.
Brief change log
Modifier#isPublic
checkVerifying this change
This change is already covered by existing tests, such as
InstantiationUtilTest
. This change added a new negative test in that class.Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (yes / no)Documentation