Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-35148][core] Improve InstantiationUtil for checking nullary pu… #24675

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

liuml07
Copy link
Member

@liuml07 liuml07 commented Apr 17, 2024

…blic constructor

What is the purpose of the change

https://issues.apache.org/jira/browse/FLINK-35148

InstantiationUtil#hasPublicNullaryConstructor checks whether the given class has a public nullary constructor. The implementation can be improved a bit: the Modifier#isPublic check within the for-loop can be skipped as the Class#getConstructors() only returns public constructors.

We can also add a negative unit test for this.

Brief change log

  • Skip the Modifier#isPublic check
  • Use Java stream
  • Add negative unit test

Verifying this change

This change is already covered by existing tests, such as InstantiationUtilTest. This change added a new negative test in that class.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@liuml07
Copy link
Member Author

liuml07 commented Apr 17, 2024

@snuyanzin could you take a look? Thanks,

@flinkbot
Copy link
Collaborator

flinkbot commented Apr 17, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@liuml07
Copy link
Member Author

liuml07 commented Apr 24, 2024

@xintongsong Could you please take a quick look at this for me? Thanks!

@xintongsong
Copy link
Contributor

@flinkbot run azure

Copy link
Contributor

@xintongsong xintongsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xintongsong xintongsong merged commit 9cc6498 into apache:master Apr 24, 2024
@liuml07 liuml07 deleted the FLINK-35148 branch April 24, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants