Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-35166][runtime] Make the SortBufferAccumulator use more buffers when the parallelism is small #24683

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

jiangxin369
Copy link
Contributor

What is the purpose of the change

Improve the performance of hybrid shuffle when enable memory decoupling and meantime the parallelism is small.

Brief change log

  • Make the SortBufferAccumulator use more buffers when the parallelism is small

Verifying this change

Please make sure both new and modified tests in this PR follow the conventions for tests defined in our code quality guide.

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@flinkbot
Copy link
Collaborator

flinkbot commented Apr 19, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@jiangxin369 jiangxin369 changed the title [FLINK-35166] Make the SortBufferAccumulator use more buffers when the parallelism is small [FLINK-35166][runtime] Make the SortBufferAccumulator use more buffers when the parallelism is small Apr 19, 2024
Copy link
Contributor

@TanYuxin-tyx TanYuxin-tyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jiangxin369 , LGTM.

Copy link
Member

@reswqa reswqa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is TPC-DS performance no longer regression after the fix?

@jiangxin369
Copy link
Contributor Author

Is TPC-DS performance no longer regression after the fix?

@reswqa The regression still exists because we replace the HashBufferAccumulator with the SortBufferAccumulator when the decoupling is enabled and the parallelism is less than 512, but this PR reduces the regression. According to the previous discussion, the regression is acceptable if the feature is enabled.

@reswqa
Copy link
Member

reswqa commented Apr 24, 2024

Is TPC-DS performance no longer regression after the fix?

@reswqa The regression still exists because we replace the HashBufferAccumulator with the SortBufferAccumulator when the decoupling is enabled and the parallelism is less than 512, but this PR reduces the regression. According to the previous discussion, the regression is acceptable if the feature is enabled.

Ah, I see. Let's keep improving it then :)

@reswqa reswqa merged commit 712d980 into apache:master Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants