Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-33722] Fix events ordering in MATCH_RECOGNIZE in batch mode #24699

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

grzegorz8
Copy link

What is the purpose of the change

Currently, MATCH_RECOGNIZE completely ignores the ORDER BY clause in batch mode: the events are processed in the order they come which makes no sense. This pull request adds proper events ordering in Pattern Recognition for batch.

Brief change log

  • Fix events ordering in MATCH_RECOGNIZE in batch mode

Verifying this change

This change added tests and can be verified with org.apache.flink.table.planner.runtime.batch.sql.MatchRecognizeITCase. Existing tests have been modified.
A few new tests have been added - they are simiar to the ones in org.apache.flink.table.planner.runtime.stream.sql.MatchRecognizeITCase.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@flinkbot
Copy link
Collaborator

flinkbot commented Apr 22, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants