Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-32843][JUnit5 Migration] Migrate the jobmaster package of flink-runtime module to JUnit5 #24723

Merged
merged 5 commits into from May 6, 2024

Conversation

RocMarshal
Copy link
Contributor

What is the purpose of the change

[FLINK-32843][JUnit5 Migration] Migrate the jobmaster package of flink-runtime module to JUnit5

Brief change log

  • Remove the TestingComponentMainThreadExecutor.Resource

  • Remove the deprecated PhysicalSlotProviderResource.java

  • Migrate the jobmaster package of flink-runtime module to JUnit5

  • Introduce the PhysicalSlotProviderExtension.java to replace the PhysicalSlotProviderResource.java

  • Add the comments about deprecated details for TestingComponentMainThreadExecutor.Resource

Verifying this change

Please make sure both new and modified tests in this PR follow the conventions for tests defined in our code quality guide.

This change is already covered by existing tests, such as (please describe tests).

This change added tests and can be verified as follows:

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

…ension.java to replace the PhysicalSlotProviderResource.java
@RocMarshal
Copy link
Contributor Author

Hi, @Jiabao-Sun @caicancai Could you help have a check on it if you had the free time ?
Thank you !

@flinkbot
Copy link
Collaborator

flinkbot commented Apr 25, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@Jiabao-Sun Jiabao-Sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @RocMarshal for this contribution which is overall good to me.

We can continue to minimize the visibility of methods and fields.

The methods visibility can be package-private.

@BeforeEach
public void setup()

@BeforeClass
public static void setup()

The fields visibility can be private.

@RegisterExtension
public final TestingFatalErrorHandlerExtension testingFatalErrorHandlerExtension =
     new TestingFatalErrorHandlerExtension();

Copy link
Contributor Author

@RocMarshal RocMarshal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Jiabao-Sun for the review.
I made some change based on your comments.
Would you mind taking a look ? many thanks~ :)

Copy link
Member

@caicancai caicancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I have no other opinions here

Copy link
Contributor

@Jiabao-Sun Jiabao-Sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @RocMarshal for the quick update and @caicancai for the review.
LGTM.

@Jiabao-Sun Jiabao-Sun merged commit beb0b16 into apache:master May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants