[FLINK-34902][table] Fix IndexOutOfBoundsException for VALUES #24724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeyhunkarimov
force-pushed
the
FLINK-34902-postfix
branch
from
abf08e9
to
13f15a4
Compare
|
@twalthr, would you mind taking a look at this? thanks! |
twalthr
reviewed
Apr 29, 2024
| @@ -63,6 +64,55 @@ void testInsertInto2() { | |||
| .hasMessageContaining(" Number of columns must match number of query columns"); | |||
| } | |||
|
|
|||
| @Test | |||
| void testInsertInto3() { | |||
There was a problem hiding this comment.
Tests should have a descriptive name. E.g. testInsertIntoValuesColumnsMismatch
| void testInsertInto7() { | ||
| assertDoesNotThrow( | ||
| () -> { | ||
| plannerMocks.getParser().parse("INSERT INTO t2 (a,b) Select 1, 2"); |
There was a problem hiding this comment.
Could you also add a test for INSERT INTO t2 (a) VALUES (1), (3)?
|
Hi @twalthr thanks a lot for your review. Could you please recheck in your available time? Thanks |
twalthr
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
The purpose of this PR is to avoid wrong
IndexOutOfBoundsExceptionwith Values.For example, a query
INSERT INTO t_3_columns (id, name, num) VALUES ('id_0', 'name_0', 5);should not throw an exception.Brief change log
Verifying this change
org.apache.flink.table.planner.calcite. FlinkCalciteSqlValidatorTestDoes this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation