Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-29797][flink-yarn] Fix fs.default-scheme will accidentally cau… #24733

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

slankka
Copy link
Contributor

@slankka slankka commented Apr 27, 2024

…se temporary flinkConfigFile treated as remote file. also fix [FLINK-33424]

What is the purpose of the change

If user set fs.default-scheme to hdfs://namenode or s3://any, it will cause /tmp/flink-confxxxx FileNotFoundException.

Fix FLINK-29797

also fix FLINK-33424

Brief change log

It is obvious that FileSystem will create a DistributedFileSystem while fs.default-scheme NOT set to file://.

It is obvious that temporary flink-conf.yaml or config.yaml file are created as LocalResource during submission to yarn.

Before change

There is no big diffierence between "job.graph" and flink conf file for registerSingleLocalResource except that
tmpJobGraphFile.toURI() and tmpConfigurationFile.getAbsolutePath()

After change

tmpConfigurationFile.toURI() will return correct path with file:// scheme, so registerSingleLocalResource will not treate it as remote files.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): ( no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): ( no)
  • The serializers: ( no )
  • The runtime per-record code paths (performance sensitive): ( no )
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yarn)
  • The S3 file system connector: ( no )

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

…se temporary flinkConfigFile treated as remote file. also fix [FLINK-33424]
@flinkbot
Copy link
Collaborator

flinkbot commented Apr 27, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants