Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-35262] Bridge between AsyncKeyedStateBackend and AsyncExecutionController #24740

Closed
wants to merge 2 commits into from

Conversation

masteryhx
Copy link
Contributor

What is the purpose of the change

Bridge between AsyncKeyedStateBackend and AsyncExecutionController, which make aec usable with StateBackend

Brief change log

  • Bridge between AsyncKeyedStateBackend and AsyncExecutionController
  • Support AsyncKeyedStateBackend for ForStKeyedStateBackend

Verifying this change

This change added tests and can be verified as follows:

  • Introduce method of building Async State Backend in StateBackendTestUtils
  • Modify AsyncExecutionControllerTest, AbstractAsyncStateStreamOperatorTest, AbstractAsyncStateStreamOperatorV2Test
  • Add testAsyncValueStateInstantiation in StreamingRuntimeContextTest

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Apr 29, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@fredia fredia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@masteryhx Thanks for the PR, I left some comments, please take a look.

Copy link
Contributor

@Zakelly Zakelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I left some comments

@masteryhx masteryhx force-pushed the FLINK-35262 branch 4 times, most recently from 00a1ffd to 872f45c Compare May 7, 2024 01:52
Copy link
Contributor

@Zakelly Zakelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, overall LGTM.

@masteryhx masteryhx force-pushed the FLINK-35262 branch 2 times, most recently from 53b8694 to a06c3a1 Compare May 7, 2024 11:10
@masteryhx masteryhx closed this May 8, 2024
@masteryhx masteryhx deleted the FLINK-35262 branch May 8, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants