New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-35262] Bridge between AsyncKeyedStateBackend and AsyncExecutionController #24740
Conversation
...ache/flink/streaming/runtime/operators/asyncprocessing/AbstractAsyncStateStreamOperator.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@masteryhx Thanks for the PR, I left some comments, please take a look.
...runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/AsyncExecutionController.java
Outdated
Show resolved
Hide resolved
...ing-java/src/main/java/org/apache/flink/streaming/api/operators/StreamingRuntimeContext.java
Show resolved
Hide resolved
...ebackend-forst/src/main/java/org/apache/flink/state/forst/ForStKeyedStateBackendBuilder.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I left some comments
...runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/AsyncExecutionController.java
Outdated
Show resolved
Hide resolved
...a/src/main/java/org/apache/flink/streaming/api/operators/StreamTaskStateInitializerImpl.java
Show resolved
Hide resolved
00a1ffd
to
872f45c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update, overall LGTM.
...ing-java/src/main/java/org/apache/flink/streaming/api/operators/StreamingRuntimeContext.java
Outdated
Show resolved
Hide resolved
53b8694
to
a06c3a1
Compare
What is the purpose of the change
Bridge between AsyncKeyedStateBackend and AsyncExecutionController, which make aec usable with StateBackend
Brief change log
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (yes / no)Documentation