[FLINK-35195][table] Support the execution of create materialized table in continuous refresh mode #24750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
May I ask how to find the list of issues/requests I can contribute to? |
You can find it in jira: https://issues.apache.org/jira/projects/FLINK/issues/ |
hackergin
reviewed
May 7, 2024
...g/apache/flink/table/operations/materializedtable/AlterMaterializedTableChangeOperation.java
Outdated
Show resolved
Hide resolved
...ateway/src/main/java/org/apache/flink/table/gateway/service/operation/OperationExecutor.java
Outdated
Show resolved
Hide resolved
.../java/org/apache/flink/table/gateway/service/materializedtable/MaterializedTableManager.java
Outdated
Show resolved
Hide resolved
.../java/org/apache/flink/table/gateway/service/materializedtable/MaterializedTableManager.java
Outdated
Show resolved
Hide resolved
...g/apache/flink/table/operations/materializedtable/AlterMaterializedTableChangeOperation.java
Outdated
Show resolved
Hide resolved
…reate generic table
… to generate execution plan for planner
…eMaterializedTableOperation
…r for continuous refresh mode
…ate materialized table refresh status and RefreshHandler
…ort drop materialized table
… for continuous refresh mode in SqlGateway
hackergin
approved these changes
May 7, 2024
| operationExecutor, handle, createMaterializedTableOperation); | ||
| } else { | ||
| throw new SqlExecutionException( | ||
| "Only support create materialized table in continuous refresh mode currently."); |
There was a problem hiding this comment.
The wording here is a bit strange. How about change it to . Currently, we only support creating materialized tables with continuous refresh mode.
| operationExecutor.callExecutableOperation( | ||
| handle, alterMaterializedTableChangeOperation); | ||
| } catch (Exception e) { | ||
| // drop materialized table while submit flink streaming job occur exception. Thus, weak |
There was a problem hiding this comment.
Suggested change
| // drop materialized table while submit flink streaming job occur exception. Thus, weak | |
| // drop materialized table while submitting flink streaming job occur exception. Thus, weak |
| } | ||
| } | ||
|
|
||
| public static CatalogMaterializedTable.LogicalRefreshMode deriveLogicalRefreshMode( |
There was a problem hiding this comment.
We can add some documentation to this function.
| } | ||
| } | ||
|
|
||
| public static CatalogMaterializedTable.RefreshMode deriveRefreshMode( |
lsyldliu
commented
May 7, 2024
There was a problem hiding this comment.
@hackergin Thanks for your reviewing, I think we can improve the minor comments in next PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Support the execution of create materialized table in continuous refresh mode
Brief change log
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation