Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-35440][Table SQL / JDBC] feat(flink-connection): support isValid for tableau #24836

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

blaskovicz
Copy link

What is the purpose of the change

Allow Tableau to connect to flink sql via jdbc driver. Currently, tableau fails when FlinkConnection#isValid is called because it is not implemented. See the associated issue for a description of the exception.

Brief change log

  • isValid returns true always for FlinkConnection

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@flinkbot
Copy link
Collaborator

flinkbot commented May 24, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

// to support jdbc tools such as Tableau.
@Override
public boolean isValid(int timeout) throws SQLException {
return true;
Copy link
Contributor

@jectpro7 jectpro7 May 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it check the closed flag rather than just return ture?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants