[FLINK-35585] Add documentation for distribution #24929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twalthr
reviewed
Jun 13, 2024
| @@ -406,6 +413,14 @@ Flink will assume correctness of the primary key by assuming that the columns nu | |||
|
|
|||
| Partition the created table by the specified columns. A directory is created for each partition if this table is used as a filesystem sink. | |||
|
|
|||
| ### `DISTRIBUTED BY / DISTRIBUTED INTO` | |||
There was a problem hiding this comment.
Copy the text from SupportsBucketing including examples.
There was a problem hiding this comment.
Ok, I copied in the text here: https://github.com/apache/flink/pull/24929/files#diff-d0ac52822e134b21138761d84268f080defc8323a120650f956afb697a1bf5f6R422-R456
How should the links to JavaDocs/specifics be handled? (I updated some of the text; I am not sure how to line up other details.
There was a problem hiding this comment.
You can simplify the text a bit. So that it better fits to a first-level API rather then a second-level API. First-level API is used by less experienced users.
|
Reads well. |
|
@flinkbot run azure |
superdiaodiao
pushed a commit
to superdiaodiao/flink
that referenced
this pull request
Jul 4, 2024
snuyanzin
pushed a commit
to snuyanzin/flink
that referenced
this pull request
Jul 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Add documentation to cover FLIP-376.
Documentation