Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-4108] [scala] Consider ResultTypeQueryable for input formats #2619

Closed
wants to merge 1 commit into from

Conversation

@twalthr
Copy link
Contributor

commented Oct 11, 2016

Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the How To Contribute guide.
In addition to going through the list, please provide a meaningful description of your changes.

  • General
    • The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
    • The pull request addresses only one issue
    • Each commit in the PR has a meaningful commit message (including the JIRA id)
  • Documentation
    • Documentation has been added for new functionality
    • Old documentation affected by the pull request has been updated
    • JavaDoc for public methods has been added
  • Tests & Build
    • Functionality added by the pull request is covered by tests
    • mvn clean verify has been executed successfully locally or a Travis build has passed

This PR fixes issues with input formats (i.e. the JDBC input format) in the Scala API. Now the API also considers explicit information defines with ResultTypeQueryable.

@albertoRamon

This comment has been minimized.

Copy link

commented Oct 12, 2016

Works OK ¡¡
Capture Output

Thanks, Alb

Copy link
Contributor

left a comment

PR looks good to me.
+1 to merge once the unnecessary change is reverted.

@@ -110,7 +110,7 @@ class ExecutionEnvironment(javaEnv: JavaEnv) {
*/
@PublicEvolving
def getRestartStrategy: RestartStrategyConfiguration = {
javaEnv.getRestartStrategy()
javaEnv.getRestartStrategy

This comment has been minimized.

Copy link
@fhueske

fhueske Oct 14, 2016

Contributor

We call methods on Java objects with parentheses.

This comment has been minimized.

Copy link
@fhueske

fhueske Oct 14, 2016

Contributor

Apparently this is not the case in this class. Similar method are also called without parentheses. So lets keep this change to have consistent code in this class.

@fhueske

This comment has been minimized.

Copy link
Contributor

commented Oct 14, 2016

Merging

fhueske added a commit to fhueske/flink that referenced this pull request Oct 14, 2016
fhueske added a commit to fhueske/flink that referenced this pull request Oct 14, 2016
asfgit pushed a commit that referenced this pull request Oct 15, 2016
@asfgit asfgit closed this in dc99deb Oct 15, 2016
liuyuzhong pushed a commit to liuyuzhong/flink that referenced this pull request Dec 5, 2016
skidder added a commit to muxinc/flink that referenced this pull request Dec 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.