[FLINK-4108] [scala] Consider ResultTypeQueryable for input formats #2619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Works OK ¡¡ Thanks, Alb |
fhueske
reviewed
Oct 14, 2016
| @@ -110,7 +110,7 @@ class ExecutionEnvironment(javaEnv: JavaEnv) { | |||
| */ | |||
| @PublicEvolving | |||
| def getRestartStrategy: RestartStrategyConfiguration = { | |||
| javaEnv.getRestartStrategy() | |||
| javaEnv.getRestartStrategy | |||
There was a problem hiding this comment.
We call methods on Java objects with parentheses.
There was a problem hiding this comment.
Apparently this is not the case in this class. Similar method are also called without parentheses. So lets keep this change to have consistent code in this class.
|
Merging |
fhueske
pushed a commit
to fhueske/flink
that referenced
this pull request
Oct 14, 2016
fhueske
pushed a commit
to fhueske/flink
that referenced
this pull request
Oct 14, 2016
asfgit
pushed a commit
that referenced
this pull request
Oct 15, 2016
liuyuzhong
pushed a commit
to liuyuzhong/flink
that referenced
this pull request
Dec 5, 2016
skidder
pushed a commit
to muxinc/flink
that referenced
this pull request
Dec 27, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the How To Contribute guide.
In addition to going through the list, please provide a meaningful description of your changes.
mvn clean verifyhas been executed successfully locally or a Travis build has passedThis PR fixes issues with input formats (i.e. the JDBC input format) in the Scala API. Now the API also considers explicit information defines with ResultTypeQueryable.