[backport] [FLINK-4932] [exec graph] Failing in state RESTARTING only fails the EG if no more restarts are possible #2711
Conversation
tillrohrmann
force-pushed
the
backportFixRestartingState
branch
from
2d29714
to
f71cc3c
Compare
|
Code changes and updated figure look good to me. +1 to merge after Travis passes. It makes sense that for instance a job with infinite restarts will only be failed if the job is explicitly suspended or forced to suppress restarts. I was curious how you noticed this issue? Did a user run into this? |
|
Thanks for the review @uce. @StephanEwen actually discovered this problem. The problem was related to #2700. When the scheduleOrUpdateConsumers call was triggered when in state restarting due to a late rpc, it would fail the complete Will rebase the PR, because release-1.1 contained a problem which prevented it from building. |
…EG if no more restarts are possible If in state RESTARTING a failure occurs, then a new restart attempt is started. Only if the restart strategy no longer allows further restarts or if the thrown exception is of type SuppressRestartsException a job can go from RESTARTING into FAILED. Fix failing test cases: ExecutionGraphMetricsTest and ExecutionGraphRestartTest
tillrohrmann
force-pushed
the
backportFixRestartingState
branch
from
f71cc3c
to
d833fea
Compare
|
Thanks for the fix! |
…nly fails terminally if no more restarts are possible If in state RESTARTING a failure occurs, then a new restart attempt is started. Only if the restart strategy no longer allows further restarts or if the thrown exception is of type SuppressRestartsException a job can go from RESTARTING into FAILED. Fix failing test cases: ExecutionGraphMetricsTest and ExecutionGraphRestartTest This closes apache#2711
|
Closing this because it has been merged into the release 1.1 branch. |
…nly fails terminally if no more restarts are possible If in state RESTARTING a failure occurs, then a new restart attempt is started. Only if the restart strategy no longer allows further restarts or if the thrown exception is of type SuppressRestartsException a job can go from RESTARTING into FAILED. Fix failing test cases: ExecutionGraphMetricsTest and ExecutionGraphRestartTest This closes apache#2711
This PR is a backport of #2710 for the release-1.1 branch.
If in state RESTARTING a failure occurs (
ExecutionGraph.failis called), then a new restart attempt is started. Only if the restart strategy no longer allows further restarts or if the thrown exception is of type SuppressRestartsException a job can go from RESTARTING into FAILED.