[FLINK-4960] Allow the AbstractStreamOperatorTestHarness to test scaling down #2747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kl0u
force-pushed
the
scaling_down_tests
branch
from
b129eac
to
a627704
Compare
|
R: @aljoscha |
aljoscha
requested changes
Nov 3, 2016
| * on different instances of {@link AbstractStreamOperatorTestHarness} (each one representing one subtask) | ||
| * and repacks them into a single {@link OperatorStateHandles} so that the parallelism of the test | ||
| * can change arbitrarily (i.e. be able to scale both up and down). | ||
| * <p/> |
There was a problem hiding this comment.
A new paragraph should start with <p>. <p/> should never be used in Javadoc, AFAIK.
| Collection<KeyGroupsStateHandle> rawKeyedState = handle.getRawKeyedState(); | ||
|
|
||
|
|
||
| if ((managedOperatorState != null && managedOperatorState.size() > 1) || |
There was a problem hiding this comment.
Is this restriction necessary? I think it would also work if there are several entries in the list and we just add them all together.
|
@aljoscha thanks for the comments. I integrated them. |
|
I merged this. Thanks for your work! 😃 Could you please close this and the Jira issue? |
|
Thanks @aljoscha . Will do that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title describes, this PR just adds a method in the
AbstractStreamOperatorTestHarnessthat allows multiple partial operator states takes with thesnapshot()method, to be combined into a single one. This, combined with the already existing functionality, will allow testing arbitrary rescaling scenarios.