Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-3869] WindowedStream.apply with FoldFunction is too restrictive #2835

Closed
wants to merge 1 commit into from
Closed

[FLINK-3869] WindowedStream.apply with FoldFunction is too restrictive #2835

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Nov 20, 2016

This pull request removes the restriction that a WindowFunction in a fold/apply should emit the same type as the accumulator type of the fold. It brings the following changes to the Java and Scala APIs:

  • Deprecating apply(ReduceFunction, WindowFunction) and the restrictive apply(Initial, FoldFunction, WindowFunction) methods.
  • Replacing them with two methods : reduce(ReduceFunction, WindowFunction) and a non-restrictive fold(Initial, FoldFunction, WindowFunction).
  • Changing some test classes to use the new methods.

@aljoscha
Copy link
Contributor

I merged this. Thanks a lot for your work! 😃

Could you please close this PR if our bot doesn't?

@ghost
Copy link
Author

ghost commented Nov 22, 2016

Thanks @aljoscha for looking at it and for merging. Closing the PR.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants