[FLINK-4798] CEPITCase.testSimpleKeyedPatternCEP test failure #2843
Conversation
- Use TestListResultSink instead of writing tests results on disk to avoid IO issues - Move TestListResultSink from flink-tests_2.10 to flink-test-utils_2.10 to avoid IO issues unnecessary dependencies
|
Which "known issue" are you referring to? |
| @@ -361,17 +351,18 @@ public String select(Map<String, Event> pattern) { | |||
| } | |||
| ); | |||
|
|
|||
| result.writeAsText(resultPath, FileSystem.WriteMode.OVERWRITE); | |||
| result.addSink(resultSink); | |||
There was a problem hiding this comment.
How about using DataStreamUtils#collect() here? Then we wouldn't need to move that sink class around.
There was a problem hiding this comment.
I didn't find any of useDataStreamUtils#collect() in Flink tests.
DataStreamUtils#collect() places in <artifactId>flink-contrib</artifactId> module. Are you sure that is a good idea to depend on it?
I moved classes because I saw at least four implementations String\List sinks for testing purpose. I guess it's a good idea to migrate to one of them and get rid of usage temp files where possible.
What do you think? I'm newbie in a Flink and maybe wrong understand smth
There was a problem hiding this comment.
wasn't aware that it sits in flink-contrib, nevermind my previous comment then.
BorisOsipov
changed the title
|
These changes not needed after FLINK-5332 fix. |
I've reproduced this issue and found that it is a known issue.