Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-4895] Drop Hadoop1 support #2850

Merged
merged 1 commit into from Nov 30, 2016
Merged

[FLINK-4895] Drop Hadoop1 support #2850

merged 1 commit into from Nov 30, 2016

Conversation

rmetzger
Copy link
Contributor

I've removed all the infrastructure in Maven and the tools/ directory to get rid of Hadoop1.

I didn't test the update to the release script. So it might happen that we run into issues when doing the next release.

@greghogan
Copy link
Contributor

Does Flink build against Hadoop 3.0.0-alpha1?

@rmetzger
Copy link
Contributor Author

I haven't tried it yet.

@StephanEwen
Copy link
Contributor

Nice!

There is one more place that we can cleanup: hflush() and hsync() on FsDataOutputStream are implemented via reflection to make it work with Hadoop 1. We can remove that trick now.

See here: https://github.com/apache/flink/blob/master/flink-runtime/src/main/java/org/apache/flink/runtime/fs/hdfs/HadoopDataOutputStream.java#L143

@rmetzger
Copy link
Contributor Author

Good catch. I removed the reflection magic from the class.

@StephanEwen
Copy link
Contributor

Looks good to me.

+1 to merge this

@rmetzger
Copy link
Contributor Author

Thank you for the review. I'll merge it once travis is green.

@asfgit asfgit merged commit ac7d871 into apache:master Nov 30, 2016
@rmetzger rmetzger deleted the flink4895 branch November 30, 2016 15:28
liuyuzhong pushed a commit to liuyuzhong/flink that referenced this pull request Dec 2, 2016
liuyuzhong pushed a commit to liuyuzhong/flink that referenced this pull request Dec 5, 2016
static-max pushed a commit to static-max/flink that referenced this pull request Dec 13, 2016
joseprupi pushed a commit to joseprupi/flink that referenced this pull request Feb 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants