[FLINK-5149] let ContinuousEventTimeTrigger fire at the end of the window #2860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndow This changes the ContinuousEventTimeTrigger to behave like the EventTimeTrigger in the sense that it also triggers at the end of the window.
|
There's also #2803 ... 😉 |
|
I thinks it's fine, though, and will close my PR and Issue. Please go ahead and merge. |
|
Thanks, I'll leave this open for a bit. I wasn't aware we also had an issue for removing the trigger. I don't know how useful it is to users. |
asfgit
pushed a commit
that referenced
this pull request
Nov 24, 2016
…ndow This changes the ContinuousEventTimeTrigger to behave like the EventTimeTrigger in the sense that it also triggers at the end of the window. This prevents the trigger from not firing at all in case the first trigger interval is after the window end. This closes #2860. [typo] fix toString() of ContinuousEventTimeTrigger This closes #2854.
alpinegizmo
pushed a commit
to alpinegizmo/flink
that referenced
this pull request
Nov 28, 2016
…ndow This changes the ContinuousEventTimeTrigger to behave like the EventTimeTrigger in the sense that it also triggers at the end of the window. This prevents the trigger from not firing at all in case the first trigger interval is after the window end. This closes apache#2860. [typo] fix toString() of ContinuousEventTimeTrigger This closes apache#2854.
liuyuzhong
pushed a commit
to liuyuzhong/flink
that referenced
this pull request
Dec 5, 2016
…ndow This changes the ContinuousEventTimeTrigger to behave like the EventTimeTrigger in the sense that it also triggers at the end of the window. This prevents the trigger from not firing at all in case the first trigger interval is after the window end. This closes apache#2860. [typo] fix toString() of ContinuousEventTimeTrigger This closes apache#2854.
static-max
pushed a commit
to static-max/flink
that referenced
this pull request
Dec 13, 2016
…ndow This changes the ContinuousEventTimeTrigger to behave like the EventTimeTrigger in the sense that it also triggers at the end of the window. This prevents the trigger from not firing at all in case the first trigger interval is after the window end. This closes apache#2860. [typo] fix toString() of ContinuousEventTimeTrigger This closes apache#2854.
skidder
pushed a commit
to muxinc/flink
that referenced
this pull request
Dec 27, 2016
…ndow This changes the ContinuousEventTimeTrigger to behave like the EventTimeTrigger in the sense that it also triggers at the end of the window. This prevents the trigger from not firing at all in case the first trigger interval is after the window end. This closes apache#2860. [typo] fix toString() of ContinuousEventTimeTrigger This closes apache#2854.
joseprupi
pushed a commit
to joseprupi/flink
that referenced
this pull request
Feb 12, 2017
…ndow This changes the ContinuousEventTimeTrigger to behave like the EventTimeTrigger in the sense that it also triggers at the end of the window. This prevents the trigger from not firing at all in case the first trigger interval is after the window end. This closes apache#2860. [typo] fix toString() of ContinuousEventTimeTrigger This closes apache#2854.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the ContinuousEventTimeTrigger to behave like the
EventTimeTrigger in the sense that it also triggers at the end of the
window.