[FLINK-5002] Renamed getNumberOfUsedBuffers() method to bestEffortGetNumOfUsedBuffers(), add a check to ensure that it does not return a negative value #2865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…NumOfUsedBuffers(), add a test to check that it does not return a negative value.
|
Looks good. The test is almost a bit overkill, I think. |
…). Added check in bestEffortGetNumOfUsedBuffers(), to ensure that a return value is non-negative
MayerRoman
force-pushed
the
FLINK_5002
branch
from
a398323
to
e5043e5
Compare
MayerRoman
changed the title
|
Please check changes. |
|
Thanks, looks good. |
joseprupi
pushed a commit
to joseprupi/flink
that referenced
this pull request
Feb 12, 2017
…tEffortGetNumOfUsedBuffers() This closes apache#2865
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[FLINK-5002] Lack of synchronization in LocalBufferPool#getNumberOfUsedBuffers
According to Stefan proposal, I renamed the method and added test to make sure that the method does not return a negative value.