[FLINK-5218] [state backends] Eagerly close checkpoint streams on cancellation #2920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Streams are eagerly closed on cancellation. This is important for some stream implementations (such as HDFS) that do not properly handle thread interruption.
|
@StefanRRichter There is one change of semantics that would be good to get your input on: A checkpoint stream to which a |
|
I think the changed semantics makes actually more sense. It should also be fine for all callers, as returning null to them was also previously possible and IRC there should be no special meaning to an empty handle in 1.1. |
|
Thanks for the review, merging this... |
|
Manually merged in cc006ff |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a task is canceled during a checkpoint operation, the operation needs to cancel fast.
This is a forward fis from version 1.1, where checkpoints could get stuck when the state output streams did not handle interruptions correctly (HDFS has that problem).
Most of this is already handled in version 1.2 via the CloseableRegistry.
This adds a test to validate this case is handled correctly and adds minor changes to make it work reliably, like:
write()on closed checkpoint streamsflush()on closed checkpoint streams