[FLINK-4303] [cep] Examples for CEP library. #2937
Conversation
chermenin
changed the title
There was a problem hiding this comment.
Thank you for this contribution @chermenin! I think it'll be good to include examples for CEP.
Can you add class-level Javadocs for all of the example code? I'll like to continue to review this after they're added :)
| import org.apache.flink.streaming.api.scala.{DataStream, StreamExecutionEnvironment, createTypeInformation} | ||
| import org.apache.flink.streaming.api.windowing.time.Time | ||
|
|
||
| object CEPMonitoringExample { |
There was a problem hiding this comment.
It would be great if there's Javadoc explaining what the example demonstrates exactly.
|
|
||
| package org.apache.flink.cep.scala.examples.events | ||
|
|
||
| class MonitoringEvent(rackID: Int) { |
There was a problem hiding this comment.
Same here: Class-level Javadocs will be nice.
|
Hi @chermenin . And sorry for the really late reply. As you may have noticed the CEP library has been significantly enriched for the 1.3 version with a bunch of cool new features (and there are a lot more in the pipeline). Given this, this PR is a bit outdated, but the task of having some examples illustrating the new capabilities of the library remain. Would you still like to work on that? |
|
Thanks for your comment, but I'm afraid I don't have enough time to work on this task now. I'll just close this PR for now. It possible I'll come back to the task in the future if it will be needed. |
|
Thanks a lot @chermenin ! The same comment also holds for the branching patterns PR. The PR is outdated but the issue is still valid. So if you ever want to work on that, let us know! |
|
Hi @kl0u !
Could you give me a hint which features should be implemented in the pipline? |
|
Hi @DmytroShkvyra ! Great to hear that you want to contribute to Flink! To see the features that are pending, I would suggest to have a look at the JIRAs that have CEP as component. A good JIRA to start from, is the one from this PR (https://issues.apache.org/jira/browse/FLINK-4303). Adding examples will help you get familiarized with the new features and with the library in general. Unfortunately the documentation is not up-to-date but I am working on it and I will merge it next week. |
|
Hi @kl0u |
Added example programs written in Java and Scala. They based on @tillrohrmann 's monitoring example.
This issue will be closed by this PR: https://issues.apache.org/jira/browse/FLINK-4303.