Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-3555] Web interface does not render job information properly #2941

Closed
wants to merge 1 commit into from
Closed

[FLINK-3555] Web interface does not render job information properly #2941

wants to merge 1 commit into from

Conversation

bitchelov
Copy link
Contributor

@bitchelov bitchelov commented Dec 5, 2016

Before: When a window is minimized, the content turned out to be beyond
before

After::shipit:

after

@StephanEwen
Copy link
Contributor

Thank you for this patch.

Could you help us validate the changed behavior, for example attach a before/after screenshot of chrome or Safari that shows the difference?

@bitchelov
Copy link
Contributor Author

@StephanEwen Sure.

@bitchelov
Copy link
Contributor Author

@StephanEwen is it right?

@StephanEwen
Copy link
Contributor

Looks good, thanks for the nice animations!

Will merge this for 1.2 and 1.3 ...

@StephanEwen
Copy link
Contributor

Sorry, I have to take a step back here:

The changes you made were directly to the resulting CSS files. These files are generated by the web build scripts, so the changes have to be made to the original files. Otherwise they will be overwritten the next time somebody re-builds the web UI. See here: https://github.com/apache/flink/blob/master/flink-runtime-web/README.md

The change to flink-runtime-web/web-dashboard/web/css/index.css is easy t put into index.styl instead. However, the change in flink-runtime-web/web-dashboard/web/css/vendor.css overwrites a style that is pulled in as a dependency. Not sure how to handle this correctly.

@uce @sachingoel0101 ot @iampeter Can probably help here.

@sachingoel0101
Copy link
Contributor

Imo, the best way to achieve the change equivalent to the change to vendor.css file would be to add a new class, say, .panel-body-flowable in index.styl which defines the overflow rule, and add this class to the elements wherever needed.

@StephanEwen
Copy link
Contributor

@bitchelov do you want to follow up on this pull request?

@iampeter
Copy link
Contributor

I agree with @sachingoel0101 as for overrriding classes from vendor.css

@bitchelov
Copy link
Contributor Author

@StephanEwen yeah, sure im gonna finish this pr

@aljoscha
Copy link
Contributor

I'm closing this as "Abandoned", since there is no more activity and the code base has moved on quite a bit. Please re-open this if you feel otherwise and work should continue.

@aljoscha aljoscha closed this Oct 15, 2019
@aljoscha aljoscha self-assigned this Oct 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants