-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-3555] Web interface does not render job information properly #2941
Conversation
Thank you for this patch. Could you help us validate the changed behavior, for example attach a before/after screenshot of chrome or Safari that shows the difference? |
@StephanEwen Sure. |
@StephanEwen is it right? |
Looks good, thanks for the nice animations! Will merge this for 1.2 and 1.3 ... |
Sorry, I have to take a step back here: The changes you made were directly to the resulting CSS files. These files are generated by the web build scripts, so the changes have to be made to the original files. Otherwise they will be overwritten the next time somebody re-builds the web UI. See here: https://github.com/apache/flink/blob/master/flink-runtime-web/README.md The change to @uce @sachingoel0101 ot @iampeter Can probably help here. |
Imo, the best way to achieve the change equivalent to the change to vendor.css file would be to add a new class, say, .panel-body-flowable in index.styl which defines the overflow rule, and add this class to the elements wherever needed. |
@bitchelov do you want to follow up on this pull request? |
I agree with @sachingoel0101 as for overrriding classes from |
@StephanEwen yeah, sure im gonna finish this pr |
I'm closing this as "Abandoned", since there is no more activity and the code base has moved on quite a bit. Please re-open this if you feel otherwise and work should continue. |
Before: When a window is minimized, the content turned out to be beyond
After::shipit: