[FLINK-5261] Clean up meters in ScheduledDropwizardReporter #2944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uce
approved these changes
Dec 5, 2016
| @@ -91,6 +91,10 @@ protected ScheduledDropwizardReporter() { | |||
| return meters; | |||
| } | |||
|
|
|||
| Map<Gauge<?>, String> getGauges() { return gauges; } | |||
There was a problem hiding this comment.
Can you do a new line for the return and add a annotation like @VisibleForTesting?
| @@ -91,6 +91,10 @@ protected ScheduledDropwizardReporter() { | |||
| return meters; | |||
| } | |||
|
|
|||
| Map<Gauge<?>, String> getGauges() { return gauges; } | |||
|
|
|||
| Map<Histogram, String> getHistograms() { return histograms; } | |||
| @@ -124,6 +129,89 @@ public void testAddingMetrics() throws NoSuchFieldException, IllegalAccessExcept | |||
| metricRegistry.shutdown(); | |||
| } | |||
|
|
|||
| @Test | |||
There was a problem hiding this comment.
Can you add a high level description about what this test does please? Otherwise this looks good.
|
@uce Thank you for reviewing this so quickly, I've addressed all your comments. |
|
Going to merge this with the next batch |
static-max
pushed a commit
to static-max/flink
that referenced
this pull request
Dec 13, 2016
joseprupi
pushed a commit
to joseprupi/flink
that referenced
this pull request
Feb 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the metric-cleanup in the
ScheduledDropwizardReporter. We were missing a separate branch for meters withinnotifyOfRemovedMetric.I've also added a test case to make sure that all metric types are properly cleaned up, both on our and and from the Dropwizard registry.