[FLINK-1234] Update documentation configuration to reflect new hadoop2 default profile. #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2 default profile. Note: This is the same commit as this one for the "release-0.8" branch: 1e9420b
|
Great. Let's add this to |
| @@ -90,16 +90,16 @@ Execute the following commands: | |||
| curl https://raw.githubusercontent.com/apache/incubator-flink/master/flink-quickstart/quickstart.sh | bash | |||
| ~~~ | |||
|
|
|||
| 3. Set the the version of Flink to `{{site.FLINK_VERSION_HADOOP_2_STABLE}}` in the `pom.xml` file. The quickstart.sh script sets the version to the `hadoop1` version of Flink. Since the `microsoft-hadoop-azure` has been written for Hadoop 2.2 (mapreduce-API) version, we need to use the appropriate Flink version. | |||
| 3. Set the the version of Flink to `{{site.FLINK_VERSION_HADOOP2_STABLE}}` in the `pom.xml` file. The quickstart.sh script sets the version to the `hadoop1` version of Flink. Since the `microsoft-hadoop-azure` has been written for Hadoop 2.2 (mapreduce-API) version, we need to use the appropriate Flink version. | |||
There was a problem hiding this comment.
Is this still true? Does the quickstart.sh set the version to hadoop1 of Flink? If yes, why?
|
Thanks. +1 to merge after 0.8.0 is out. |
|
Just as a reminder: we have to check for the old variable names before merging. #292 for examples updates the docs as well and uses the old variable names. |
|
I'll merge #292 first and then fix the variable names as part of this pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This is the same commit as this one for the "release-0.8" branch: rmetzger@1e9420b