[FLINK-4704] Move Table API to org.apache.flink.table

[ex00]

Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the How To Contribute guide.
In addition to going through the list, please provide a meaningful description of your changes.

• General

  • The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
  • The pull request addresses only one issue
  • Each commit in the PR has a meaningful commit message (including the JIRA id)

• Documentation

  • Documentation has been added for new functionality
  • Old documentation affected by the pull request has been updated
  • JavaDoc for public methods has been added

• Tests & Build

  • Functionality added by the pull request is covered by tests
  • mvn clean verify has been executed successfully locally or a Travis build has passed

The PR about moving table api and sql classes to org.apache.flink.table package

[fhueske]

Thanks for the PR @ex00!

I would like to suggest to move a few more files:

• move flink-table examples: org/apache/flink/examples -> org/apache/flink/table/examples (for Java and Scala)
• move src/main/scala/org/apache/flink/table/windows.scala -> src/main/scala/org/apache/flink/table/api/windows.scala
• move src/main/scala/org/apache/flink/table/Types.scala -> src/main/scala/org/apache/flink/table/typeutils/Types.scala
• move src/main/scala/org/apache/flink/table/trees/TreeNode.scala -> src/main/scala/org/apache/flink/table/plan/TreeNode.scala and remove the empty trees package / folder
• create a new package org.apache.flink.table.calcite and move CalciteConfig.scala, FlinkCalciteSqlValidator.scala, FlinkPlannerImpl.scala, FlinkRelBuilder.scala, FlinkTypeFactory.scala, and FlinkTypeSystem.scala from src/main/scala/org/apache/flink/table to src/main/scala/org/apache/flink/table/calcite

We also need to rebase the PR to the current master and move a few files that have been added in the mean time. There was also on change in the docs that needs to be adapted.

What do you think @ex00 and @twalthr?

[twalthr]

@fhueske I would move src/main/scala/org/apache/flink/table/Types.scala to src/main/scala/org/apache/flink/table/api/. This class is API only and and not used internally.

And src/main/scala/org/apache/flink/table/table.scala -> src/main/scala/org/apache/flink/table/api/.

[fhueske]

OK @twalthr. Sounds good to me.

[ex00]

Hi @fhueske and @twalthr, thanks for your comments.
I will update PR

[ex00]

PR has been updated.

[fhueske]

Thanks for the update @ex00!
I'll do a few additional minor refactorings and merge the PR later.

Thanks, Fabian

[ex00]

Thank you Fabian!

[fhueske]

Merging this PR

[twalthr]

I looked over the changes again. LGTM also from my side.