Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-4647] Read bipartite graph #2987

Closed
wants to merge 1 commit into from

Conversation

mushketyk
Copy link
Contributor

Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the How To Contribute guide.
In addition to going through the list, please provide a meaningful description of your changes.

  • General

    • The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
    • The pull request addresses only one issue
    • Each commit in the PR has a meaningful commit message (including the JIRA id)
  • Documentation

    • Documentation has been added for new functionality
    • Old documentation affected by the pull request has been updated
    • JavaDoc for public methods has been added
  • Tests & Build

    • Functionality added by the pull request is covered by tests
    • mvn clean verify has been executed successfully locally or a Travis build has passed

@greghogan
Copy link
Contributor

There are some refactorings in #2832 which overlap with updates here.

@greghogan
Copy link
Contributor

#2832 has been committed to master. Please rebase.

@mushketyk
Copy link
Contributor Author

Hi @greghogan ,

I've rebased this PR on top of master.

@greghogan
Copy link
Contributor

@mushketyk what do you think of refactoring GraphCsvReader and BipartiteGraphCsvReader to use configuration objects using the builder patter? It would be nice to have CsvReaderConfiguration in core Flink but we could add it to Gelly first.

GraphCsvReader currently have two of everthing (fieldDelimiterEdges/fieldDelimiterVertices, ignoreCommentsEdges/ignoreCommentsVertices, ...). BipartiteGraphCsvReader looks to add three of the same. We could look into collapsing these into a single configuration object.

@aljoscha
Copy link
Contributor

I'm closing this as "Abandoned", since there is no more activity and the code base has moved on quite a bit. Please re-open this if you feel otherwise and work should continue.

@aljoscha aljoscha closed this Oct 15, 2019
@aljoscha aljoscha self-assigned this Oct 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants