-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-4861] [build] Package optional project artifacts #3014
[FLINK-4861] [build] Package optional project artifacts #3014
Conversation
Package the Flink connectors, metrics, and libraries into subdirectories of a new opt directory in the release/snapshot tarballs.
@StephanEwen or @rmetzger would you be able to review before today's code freeze? |
I can try to give it a shot later... |
@greghogan Seems I have a few more days to look at that. Will try to get back at this soon... |
Checking this out now... |
Okay, the approach of this pull request looks good, but there are two things we need to adjust:
|
I'll try to address that, then merge this pull request... |
Thanks @StephanEwen. FLINK-4782 may be related in the handling of provided dependencies (external, in that case). |
Pull request #3029 is the prerequisite for this pull request to work nicely. Once that is merged, we can merge this one here as is. |
Actually, just saw that Also, gelly and gelly-scala still have the ASM dependency (which seems not necessary any more). We should remove those dependencies, otherwise the "jar with dependency" will have not properly relocated asm classes (and we would need to define more shade profiles) |
I have an update with the mentioned changes. Will push that once #3029 gets approval. |
Package the Flink connectors, metrics, and libraries into subdirectories of a new opt directory in the release/snapshot tarballs. This closes apache#3014
Package the Flink connectors, metrics, and libraries into subdirectories of a new opt directory in the release/snapshot tarballs. This closes apache#3014
Package the Flink connectors, metrics, and libraries into subdirectories of a new opt directory in the release/snapshot tarballs. This closes apache#3014
Package the Flink connectors, metrics, and libraries into subdirectories of a new opt directory in the release/snapshot tarballs. This closes apache#3014
Package the Flink connectors, metrics, and libraries into subdirectories of a new opt directory in the release/snapshot tarballs. This closes apache#3014
Package the Flink connectors, metrics, and libraries into subdirectories of a new opt directory in the release/snapshot tarballs. This closes apache#3014
Package the Flink connectors, metrics, and libraries into subdirectories of a new opt directory in the release/snapshot tarballs.
The following artifacts are packaged by this build:
$ ls build-target/opt/
flink-cep_2.10-1.2-SNAPSHOT.jar
flink-cep-scala_2.10-1.2-SNAPSHOT.jar
flink-gelly_2.10-1.2-SNAPSHOT.jar
flink-gelly-examples_2.10-1.2-SNAPSHOT.jar
flink-gelly-scala_2.10-1.2-SNAPSHOT.jar
flink-metrics-dropwizard-1.2-SNAPSHOT.jar
flink-metrics-ganglia-1.2-SNAPSHOT.jar
flink-metrics-graphite-1.2-SNAPSHOT.jar
flink-metrics-statsd-1.2-SNAPSHOT.jar
flink-ml_2.10-1.2-SNAPSHOT.jar