Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-4861] [build] Package optional project artifacts #3014

Conversation

greghogan
Copy link
Contributor

Package the Flink connectors, metrics, and libraries into subdirectories of a new opt directory in the release/snapshot tarballs.

The following artifacts are packaged by this build:

$ ls build-target/opt/
flink-cep_2.10-1.2-SNAPSHOT.jar
flink-cep-scala_2.10-1.2-SNAPSHOT.jar
flink-gelly_2.10-1.2-SNAPSHOT.jar
flink-gelly-examples_2.10-1.2-SNAPSHOT.jar
flink-gelly-scala_2.10-1.2-SNAPSHOT.jar
flink-metrics-dropwizard-1.2-SNAPSHOT.jar
flink-metrics-ganglia-1.2-SNAPSHOT.jar
flink-metrics-graphite-1.2-SNAPSHOT.jar
flink-metrics-statsd-1.2-SNAPSHOT.jar
flink-ml_2.10-1.2-SNAPSHOT.jar

Package the Flink connectors, metrics, and libraries into subdirectories
of a new opt directory in the release/snapshot tarballs.
@greghogan
Copy link
Contributor Author

@StephanEwen or @rmetzger would you be able to review before today's code freeze?

@StephanEwen
Copy link
Contributor

I can try to give it a shot later...

@StephanEwen
Copy link
Contributor

@greghogan Seems I have a few more days to look at that. Will try to get back at this soon...

@StephanEwen
Copy link
Contributor

Checking this out now...

@StephanEwen
Copy link
Contributor

Okay, the approach of this pull request looks good, but there are two things we need to adjust:

  • The fat jar from the flink-ml project contains all dependencies. I think that is because the Maven Assembly plugin does not respect the "provided" status of the core dependencies. We should use the Maven Shade Plugin instead.

  • For the same reason, the reporter jars are quite messy. We should fix those as well.

@StephanEwen
Copy link
Contributor

I'll try to address that, then merge this pull request...

@greghogan
Copy link
Contributor Author

Thanks @StephanEwen. FLINK-4782 may be related in the handling of provided dependencies (external, in that case).

@StephanEwen
Copy link
Contributor

Pull request #3029 is the prerequisite for this pull request to work nicely. Once that is merged, we can merge this one here as is.

@StephanEwen
Copy link
Contributor

Actually, just saw that flink-gelly-scala does not build a "jar-with-dependencies".

Also, gelly and gelly-scala still have the ASM dependency (which seems not necessary any more). We should remove those dependencies, otherwise the "jar with dependency" will have not properly relocated asm classes (and we would need to define more shade profiles)

@StephanEwen
Copy link
Contributor

I have an update with the mentioned changes. Will push that once #3029 gets approval.

StephanEwen pushed a commit to StephanEwen/flink that referenced this pull request Dec 19, 2016
Package the Flink connectors, metrics, and libraries into subdirectories
of a new opt directory in the release/snapshot tarballs.

This closes apache#3014
StephanEwen pushed a commit to StephanEwen/flink that referenced this pull request Dec 20, 2016
Package the Flink connectors, metrics, and libraries into subdirectories
of a new opt directory in the release/snapshot tarballs.

This closes apache#3014
StephanEwen pushed a commit to StephanEwen/flink that referenced this pull request Dec 20, 2016
Package the Flink connectors, metrics, and libraries into subdirectories
of a new opt directory in the release/snapshot tarballs.

This closes apache#3014
StephanEwen pushed a commit to StephanEwen/flink that referenced this pull request Dec 20, 2016
Package the Flink connectors, metrics, and libraries into subdirectories
of a new opt directory in the release/snapshot tarballs.

This closes apache#3014
StephanEwen pushed a commit to StephanEwen/flink that referenced this pull request Dec 20, 2016
Package the Flink connectors, metrics, and libraries into subdirectories
of a new opt directory in the release/snapshot tarballs.

This closes apache#3014
@asfgit asfgit closed this in 5c76baa Dec 20, 2016
joseprupi pushed a commit to joseprupi/flink that referenced this pull request Feb 12, 2017
Package the Flink connectors, metrics, and libraries into subdirectories
of a new opt directory in the release/snapshot tarballs.

This closes apache#3014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants