[FLINK-5518] [input/output formats] Add null value check. #3133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR @jakubhavlik. The fix looks good. Can you add a Occasionally builds fail due to timeouts. That's nothing to worry about. I'll run the tests again before merging. Thank you. |
|
Tests added and build passed: https://travis-ci.org/jakubhavlik/flink/builds/192653463 . |
|
Thanks for the quick update @jakubhavlik. |
|
Merging |
fhueske
pushed a commit
to fhueske/flink
that referenced
this pull request
Jan 17, 2017
…lose(). This closes apache#3133
joseprupi
pushed a commit
to joseprupi/flink
that referenced
this pull request
Feb 12, 2017
…lose(). This closes apache#3133 This closes apache#243 // closing stale PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the How To Contribute guide.
In addition to going through the list, please provide a meaningful description of your changes.
General
Documentation
Tests & Build
mvn clean verifyhas been executed successfully locally or a Travis build has passed