[FLINK-1369] [types] Add support for Subclasses, Interfaces, Abstract Classes #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Classes. - Abstract classes with fields are handled as POJO types. - Interfaces and abstract classes without fields are handled as generic types. This closes apache#236 This closes apache#316
|
I will take a look at it. |
|
Looks good. You should add generics or least |
|
It's almost the same, except for the change to handle Interfaces and Abstract Classes with GenericTypeInfo, correct? The part that changes the KryoSerializer must be adapted because of my recently merged PR that allows registering types and serializers at Kryo. |
|
Yes, Pojo types with no internal fields would screw up the flat field addressing of the optimizer. |
aljoscha
added a commit
to aljoscha/flink
that referenced
this pull request
Jan 29, 2015
… Classes. - Abstract classes with fields are handled as POJO types. - Interfaces and abstract classes without fields are handled as generic types. This closes apache#236 This closes apache#316
aljoscha
added a commit
to aljoscha/flink
that referenced
this pull request
Jan 29, 2015
… Classes. - Abstract classes with fields are handled as POJO types. - Interfaces and abstract classes without fields are handled as generic types. This closes apache#236 This closes apache#316
|
@aljoscha took this PR and extended it. He'll open corresponding PRs. |
aljoscha
added a commit
to aljoscha/flink
that referenced
this pull request
Feb 9, 2015
… Classes. - Abstract classes with fields are handled as POJO types. - Interfaces and abstract classes without fields are handled as generic types. This closes apache#236 This closes apache#316
aljoscha
added a commit
to aljoscha/flink
that referenced
this pull request
Feb 10, 2015
… Classes. - Abstract classes with fields are handled as POJO types. - Interfaces and abstract classes without fields are handled as generic types. This closes apache#236 This closes apache#316
aljoscha
added a commit
to aljoscha/flink
that referenced
this pull request
Feb 10, 2015
… Classes. - Abstract classes with fields are handled as POJO types. - Interfaces and abstract classes without fields are handled as generic types. This closes apache#236 This closes apache#316
marthavk
pushed a commit
to marthavk/flink
that referenced
this pull request
Jun 9, 2015
… Classes. - Abstract classes with fields are handled as POJO types. - Interfaces and abstract classes without fields are handled as generic types. This closes apache#236 This closes apache#316
zhijiangW
pushed a commit
to zhijiangW/flink
that referenced
this pull request
Apr 13, 2020
…PI. (apache#316) Co-authored-by: Markos Sfikas <markos@data-artisans.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rebased PR #236 to the current master.
Some tests were failing and I had a closer look. The original PR handled interfaces and abstract classes without member variables as POJO types. However, POJO types without members cannot be handled correctly and do also not have members that can be referenced as keys or fields.
I changed the logic such that interfaces and abstract classes without members are handled as GenericTypes.
I'm not so familiar with the TypeExtractor, so it would be good if someone else could have a quick look.