[FLINK-5602] migration namespace serializer #3200
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uce
reviewed
Jan 24, 2017
| import java.io.IOException; | ||
| import java.io.Serializable; | ||
|
|
||
| public class MigrationNamespaceSerializerProxy extends TypeSerializer<Serializable> { |
There was a problem hiding this comment.
I would add short class level JavaDoc.
|
|
||
| public class MigrationNamespaceSerializerProxy extends TypeSerializer<Serializable> { | ||
|
|
||
| public static MigrationNamespaceSerializerProxy INSTANCE = new MigrationNamespaceSerializerProxy(); |
|
|
||
| @Override | ||
| public TypeSerializer<Serializable> duplicate() { | ||
| return new MigrationNamespaceSerializerProxy(); |
| && stateSerializer.isCompatibleWith(other.stateSerializer); | ||
| return (stateSerializer.isCompatibleWith(other.stateSerializer)) && | ||
| (namespaceSerializer.isCompatibleWith(other.namespaceSerializer) | ||
| || other.namespaceSerializer instanceof MigrationNamespaceSerializerProxy); |
There was a problem hiding this comment.
I would add a short comment that it's important to check for the MigrationNamespaceSerializerProxy. It could even warrant a test. I can see how someone removes this line in the future.
StefanRRichter
force-pushed
the
FLINK-5602-MigrationNamespaceSerializer
branch
from
49d374f
to
3133fd0
Compare
|
Thanks for the review @uce ! I changed my PR according to your suggestions (except for only throwing an unsupported op exception on the duplicate function). |
|
OK thanks! Makes sense with the UnsupportedOpException. I thought that duplicate is called somewhere maybe. I'll merge this as soon as Travis gives the green light. |
StefanRRichter
force-pushed
the
FLINK-5602-MigrationNamespaceSerializer
branch
from
3133fd0
to
45af1c2
Compare
|
Verified that this fixes the issue. Thanks! Merging this with together with #3198. |
joseprupi
pushed a commit
to joseprupi/flink
that referenced
this pull request
Feb 12, 2017
This closes apache#3200. This closes apache#3198.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes FLINK-5602. We introduce an artificial namespace serializer instead of
nullso that checkpoints can run even before the user states are registered.This sits on top of PR #3198 .