Rename coGroupDataSet.scala to CoGroupDataSet.scala, and crossDataSet.scala to CrossDataSet.scala #324
Conversation
….scala to CrossDataSet.scala
The UnfinishedCoGroupOperation does not relate closely to CoGroupOperation via sealed modifier so per Scala style guide [1] I propose to move it to separate file. [1] http://docs.scala-lang.org/style/files.html
|
FYI @aljoscha |
|
Why do you want to move them?
|
|
I rename the file from coGroupDataSet.scala to CoGroupDataSet.scala and crossDataSet.scala to CrossDataSet.scala to follow convention Scala file naming. And move out UnfinishedCoGroupOperation class because it is a high level public class by itself and not dependent on CoGroupOperation as sealed trait. |
|
If no more comment will merge this and 0.8.x branch by end of day tomorrow. |
|
Looks good to me. It does not break the API, since it only moves source code, so I do not have any objections. I would merge it into the master, though, not into 0.8. |
|
The problem is that if we do not merge to 0.8.x branch then if we have fixes in those file would it create weird conflict when trying to cherry-pick? |
|
Can a brutha get some +1s for this one? =) |
|
You have my +1 |
|
Cool, thanks @StephanEwen, if no one beats me merging I will do this EOD today |
|
As per recommendation from @StephanEwen, will NOT merge this to 0.8 until we need to cherry-pick fixes related to these files. |
This PR contains changes to follow Scala style:
-) Rename coGroupDataSet.scala to CoGroupDataSet.scala, and crossDataSet.scala to CrossDataSet.scala
-) Move the UnfinishedCoGroupOperation class into its own Scala file