[FLINK-5024] [core] Refactor the interface of State and StateDescriptor #3243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aljoscha
reviewed
Jan 31, 2017
| * object given a {@link StateBackend} using {@link #bind(StateBackend)}. | ||
| * | ||
| * Base class for state descriptors. A {@code StateDescriptor} is used for creating | ||
| * {@link State keyed state} in stateful operations. The descriptor contains the name of the state, |
There was a problem hiding this comment.
Just a quick note: StateDescriptors are also used for non-keyed state, i.e. operator state.
There was a problem hiding this comment.
Please close this issue as well if you address this here: https://issues.apache.org/jira/browse/FLINK-5599
|
Subsumed by another pull request... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactored version of #2768
This pull request splits the
StateDescriptor:StateDescriptor: This only contains only the informationSimpleStateDescriptoris the base of all currently used states and holds the information about a single serializer, for the state type.CompositeStateDescriptorthat would have multiple serializers, such as for the upcomingMapState.This is technically not API-breaking, since it only touches methods with
@PublicEvolvingannotations.We should think carefully, though, because this may affect all users that use the state API on
RuntimeContextand on theTriggerContext(in custom windows).