Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-2908] [web frontend] Redraw web plan when browser resized #3251

Conversation

greghogan
Copy link
Contributor

Redraw the job plan visual graph when the browser width is increased.

Redraw the job plan visual graph when the browser width is increased.
@uce
Copy link
Contributor

uce commented Feb 3, 2017

Hey Greg, I checked out the PR and still had the behaviour described in the JIRA (checked with Firefox and Chrome). Note that refreshing the page after resizing does also not change anything for me. There is a high chance that my setup is causing this, but is there a way to double check this? Could you maybe post a screenshot of the expected output after resizing the width (w/o refreshing) comparing it to the non-fixed version?

@greghogan
Copy link
Contributor Author

@uce thanks for looking at this and my apologies for not including screenshots. I am also using Firefox. An explicit page reload should force page assets to be redownloaded.

Currently switching browser to fullscreen does not resize the job graph SVG:
screen shot 2017-02-03 at 15 03 13

With this PR the SVG is resized to fill the space:
screen shot 2017-02-03 at 15 07 58

@uce
Copy link
Contributor

uce commented Feb 9, 2017

Thanks for the screenshots. My job was simple too narrow (not enough operators). After trying with a job that has more operators, I could reproduce the fix. Initially, I though that redrawing meant "zooming in" to fill the preview window.

+1 to merge, great fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants