Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-3026] Publish the flink docker container to the docker registry #3493

Closed
wants to merge 2 commits into from

Conversation

iemejia
Copy link
Member

@iemejia iemejia commented Mar 8, 2017

Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the How To Contribute guide.
In addition to going through the list, please provide a meaningful description of your changes.

  • General

    • The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
    • The pull request addresses only one issue
    • Each commit in the PR has a meaningful commit message (including the JIRA id)
  • Documentation

    • Documentation has been added for new functionality
    • Old documentation affected by the pull request has been updated
    • JavaDoc for public methods has been added
  • Tests & Build

    • Functionality added by the pull request is covered by tests
    • mvn clean verify has been executed successfully locally or a Travis build has passed

@iemejia
Copy link
Member Author

iemejia commented Mar 8, 2017

R: @greghogan
cc: @jgrier @patricklucas

@patricklucas
Copy link
Contributor

Thanks @iemejia. I have a branch building on @jgrier's commits from #3205 which I hope to push before any further changes are made. Hopefully I can get it done today.

@iemejia
Copy link
Member Author

iemejia commented Mar 8, 2017

Cool ! Just ping me when you are done and I will rebase to finish the clean ups, I am going to start contacting the docker people to see what else do we need and continue to work in the ubuntu version meanwhile (I think having both is worth even if it was me who slimmed the thing into alpine).

@patricklucas
Copy link
Contributor

I took a look through the top official Docker repos to see what variants they provide, and the first-listed Java-based project is Elasticsearch. They have two variants for each of their supported version, alpine and non-alpine which are based on openjdk:8-jre and openjdk:8-jre-alpine respectively.

Can you point me at other official repos basing on debian/ubuntu images?

@patricklucas
Copy link
Contributor

I've opened my PR, #3494.

@iemejia
Copy link
Member Author

iemejia commented Mar 8, 2017

Yes, maybe I was not clear enough, my goal is to support the two variants of openjdk that you mention.
I was just mentioning ubuntu/debian because this is the base of the non-alpine base container for openjdk.
https://github.com/docker-library/openjdk/blob/445f8b8d18d7c61e2ae7fda76d8883b5d51ae0a5/8-jre

So we will need some small tweaks and an extra Dockerfile to support both.

For other images that support both openjdk base and the alpine version.
https://hub.docker.com/_/solr/
https://hub.docker.com/_/jenkins/
https://hub.docker.com/_/tomcat/

@patricklucas
Copy link
Contributor

Aha, I see. I didn't follow the chain up further. :)

Then yes, I'm generally on board with following this convention.

@patricklucas
Copy link
Contributor

Since this PR is no longer directly related to publishing official Docker images, could you change its title? (See my reply to your comment on #3494)

@iemejia
Copy link
Member Author

iemejia commented Mar 8, 2017

I will, and add the commits for the ubuntu image, probably I will create a JIRA for this.

@iemejia
Copy link
Member Author

iemejia commented Mar 8, 2017

I oups not the ubuntu, the non-alpine one :)

@iemejia
Copy link
Member Author

iemejia commented Mar 8, 2017

I am closing this to create a new one based on the new JIRA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants