New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-3026] Publish the flink docker container to the docker registry #3493
Conversation
R: @greghogan |
The java image is deprecated from the official docker images since 2016/12.
Cool ! Just ping me when you are done and I will rebase to finish the clean ups, I am going to start contacting the docker people to see what else do we need and continue to work in the ubuntu version meanwhile (I think having both is worth even if it was me who slimmed the thing into alpine). |
I took a look through the top official Docker repos to see what variants they provide, and the first-listed Java-based project is Elasticsearch. They have two variants for each of their supported version, alpine and non-alpine which are based on openjdk:8-jre and openjdk:8-jre-alpine respectively. Can you point me at other official repos basing on debian/ubuntu images? |
I've opened my PR, #3494. |
Yes, maybe I was not clear enough, my goal is to support the two variants of openjdk that you mention. So we will need some small tweaks and an extra Dockerfile to support both. For other images that support both openjdk base and the alpine version. |
Aha, I see. I didn't follow the chain up further. :) Then yes, I'm generally on board with following this convention. |
Since this PR is no longer directly related to publishing official Docker images, could you change its title? (See my reply to your comment on #3494) |
I will, and add the commits for the ubuntu image, probably I will create a JIRA for this. |
I oups not the ubuntu, the non-alpine one :) |
I am closing this to create a new one based on the new JIRA |
Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the How To Contribute guide.
In addition to going through the list, please provide a meaningful description of your changes.
General
Documentation
Tests & Build
mvn clean verify
has been executed successfully locally or a Travis build has passed