[FLINK-6025] [core] Add Flink's own JavaSerializer for Kryo serialization #3517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion This commit adds a reimplemented JavaSerializer to be registered with Kryo. This is due to a know issue with Kryo's JavaSerializer that may use the wrong classloader for deserialzation. Instead of registering Kryo's JavaSerializer for Throwables, it is now changed to register the reimplemented JavaSerializer. Users who bump into ClassNotFoundExceptions if they are using Kryo's JavaSerializer for their own types are also recommended to change to Flink's JavaSerializer.
|
Good change, +1 to merge |
|
Thank you for the reviews @rmetzger! I'll proceed to merge this and the backport PRs. |
p16i
pushed a commit
to p16i/flink
that referenced
this pull request
Apr 16, 2017
…tion This commit adds a reimplemented JavaSerializer to be registered with Kryo. This is due to a know issue with Kryo's JavaSerializer that may use the wrong classloader for deserialzation. Instead of registering Kryo's JavaSerializer for Throwables, it is now changed to register the reimplemented JavaSerializer. Users who bump into ClassNotFoundExceptions if they are using Kryo's JavaSerializer for their own types are also recommended to change to Flink's JavaSerializer. This closes apache#3517.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a reimplemented
JavaSerializerto be registered withKryo. This is due to a know issue with Kryo's
JavaSerializerthat mayuse the wrong classloader for deserialzation (see EsotericSoftware/kryo#483).
Since we by default register Kryo's
JavaSerializerforThrowables, users who need to serialize exception types as messages bump intoClassNotFoundExceptions.Instead of registering Kryo's
JavaSerializerforThrowables, it is now changed to register the reimplementedJavaSerializer.Generally, users who bump into
ClassNotFoundExceptions if they are using Kryo'sJavaSerializerfortheir own custom types are also recommended to change to Flink's
JavaSerializer.The change is tested using the minimal issue reproducing example provided by our users in http://apache-flink-user-mailing-list-archive.2336050.n4.nabble.com/AWS-exception-serialization-problem-td12063.html.