[FLINK-6050] [robustness] Register exception handler on thenAccept futures #3537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is good, +1 Do we have a test that validates that completing a |
|
Thanks for the review @StephanEwen. I will check whether we have such a test case and if not, I'll add it. |
…y increasing timeout In order to check whether the heartbeat manager detects timeouts we wait on the JobMasterGateway.disconnectTaskManager call which happens asynchronously. In order to harden the test, we increase the timeout from 50 ms to 500 ms for the timeout call to happen.
…tures When applying an AcceptFunction on a Future x, then we should register the exception handler on the returned thenAccept future instead of on x. This has the advantage that we also catch exceptions which are thrown inside of the AcceptFunction and not only those which originate from x. The PR adapts the code respectively. This closes apache#3537.
tillrohrmann
force-pushed
the
hardenAcceptFutureCalls
branch
from
6a07f61
to
a52925f
Compare
p16i
pushed a commit
to p16i/flink
that referenced
this pull request
Apr 16, 2017
…tures When applying an AcceptFunction on a Future x, then we should register the exception handler on the returned thenAccept future instead of on x. This has the advantage that we also catch exceptions which are thrown inside of the AcceptFunction and not only those which originate from x. The PR adapts the code respectively. This closes apache#3537.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When applying an AcceptFunction on a Future x, then we should register the exception handler
on the returned thenAccept future instead of on x. This has the advantage that we also catch
exceptions which are thrown inside of the AcceptFunction and not only those which originate
from x. The PR adapts the code respectively.