[FLINK-6059] [table] Reject GenericType<Row> when converting DataSet or DataStream to Table #3546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -498,6 +505,10 @@ abstract class TableEnvironment(val config: TableConfig) { | |||
| TableEnvironment.validateType(inputType) | |||
There was a problem hiding this comment.
Can we do the GenericTypeInfo type check in TableEnvironment.validateType(inputType) method? If we do so, we can remove the duplicate check. What do you think?
Best,
SunJincheng
There was a problem hiding this comment.
The validateType() method is also used to check the output type, i.e., the type of a DataSet or DataStream which is created from a Table. I think we should allow GenericType<Row> in that case.
Hence, I would keep the validateType() method as it is.
…or DataStream to Table.
fhueske
force-pushed
the
tableNoGenericRow
branch
from
0064a9e
to
023712f
Compare
|
Thanks for the review @sunjincheng121. Cheers, Fabian |
fanyon
pushed a commit
to fanyon/flink
that referenced
this pull request
May 11, 2017
…or DataStream to Table. This closes apache#3546.
hequn8128
pushed a commit
to hequn8128/flink
that referenced
this pull request
Jun 22, 2017
…or DataStream to Table. This closes apache#3546.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When converting a
DataSet<Row>orDataStream<Row>into aTablewhich hasGenericTypeInfo<Row>type, the row is treated as atomic type. This is always a non-expected and confusing behavior.With this change converting a
DataSet<Row>orDataStream<Row>withGenericTypeInfo<Row>into aTablefails. Instead we ask for aDataSet<Row>orDataStream<Row>with properRowTypeInfo.